Skip to content

Remove RequestError::Ignored #4399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Remove RequestError::Ignored #4399

wants to merge 3 commits into from

Conversation

@dhardy
Copy link
Contributor

@dhardy dhardy commented Nov 3, 2025

  • Tested on all platforms changed
  • Added an entry to the changelog module if knowledge of this change could be valuable to users
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • Created or updated an example program if it would help users understand this functionality

Variant Ignored was ambiguous and potentially incorrect. Specific changes:

  • set_cursor_hittest now returns Os errors on X11
  • drag_window now returns NotSupported if the current event is missing on AppKit
  • SurfaceSizeWriter now returns NotSupported should the writer outlive its context

Motivation is to impl From<RequestError> for EventLoopError.

@dhardy dhardy mentioned this pull request Nov 4, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kchibisov kchibisov Awaiting requested review from kchibisov kchibisov is a code owner

@madsmtm madsmtm Awaiting requested review from madsmtm madsmtm is a code owner

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@dhardy